← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~rharding/launchpad/yui3-5-1-dammit into lp:launchpad

 

Richard Harding has proposed merging lp:~rharding/launchpad/yui3-5-1-dammit into lp:launchpad.

Commit message:
Update to using YUI 3.5.1 as the default JS library target.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~rharding/launchpad/yui3-5-1-dammit/+merge/126015

Make YUI 3.5.1 the default for all purposes. This means that all JS tests will run under the 3.5.1 version of the library. 

YAY!
-- 
https://code.launchpad.net/~rharding/launchpad/yui3-5-1-dammit/+merge/126015
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rharding/launchpad/yui3-5-1-dammit into lp:launchpad.
=== modified file 'Makefile'
--- Makefile	2012-08-29 15:17:11 +0000
+++ Makefile	2012-09-24 14:02:23 +0000
@@ -37,7 +37,7 @@
 JS_BUILD_DIR := build/js
 YUI_VERSIONS := 3.3.0 3.5.1
 YUI_BUILDS := $(patsubst %,$(JS_BUILD_DIR)/yui-%, $(YUI_VERSIONS))
-YUI_DEFAULT := $(JS_BUILD_DIR)/yui-3.3.0
+YUI_DEFAULT := $(JS_BUILD_DIR)/yui-3.5.1
 JS_YUI := $(shell utilities/yui-deps.py $(JS_BUILD:raw=))
 JS_LP := $(shell find -L $(JS_LP_PATHS) -name '*.js' ! -name '.*.js')
 JS_ALL := $(JS_YUI) $(JS_LP)


Follow ups