launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The purpose of _constraints_map is a bit obscure.  Could you provide it with a clear comment?

Meaningful names (unlike "s") also help.  Consider introducing a meaningfully-named intermediate variable, such as:

constraints = ['name', 'tags', 'arch', 'cpu_count']
constraints_map = dict(zip(constraints, constraints))
-- 
https://code.launchpad.net/~gz/maas/cpu_mem_tag_constraints/+merge/126502
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~gz/maas/cpu_mem_tag_constraints into lp:maas.