launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

You're adding quite a lot of code to NodeManager.get_available_node_for_acquisition, with a fair amount of indentation.  That's usually a pretty good indicator that it's time to extract bits of the work into their own functions.  Which in turn can help you test them more thoroughly more conveniently.
-- 
https://code.launchpad.net/~gz/maas/cpu_mem_tag_constraints/+merge/126502
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~gz/maas/cpu_mem_tag_constraints into lp:maas.