launchpad-reviewers team mailing list archive

[John A Meinel <john@xxxxxxxxxxxxxxxxx>]

most classes seem to def __unicode__ rather than def __str__, I'm guessing with stuff like 'unicode_literals' we should probably continue to follow that.

It does look like the stuff inside the loop could be pulled out into a helper function, as JTV mentioned.

Probably something that takes available_nodes and constraints and returns a new available_nodes.


I think Tag.get_tag_or_404 is a reasonable start point, but not the greatest place to be in the end. Since it gives a NOT_FOUND rather than BAD_REQUEST. IMO it shouldn't 404, because the URL requested exists, one of the *parameters* to the URL doesn't.



-- 
https://code.launchpad.net/~gz/maas/cpu_mem_tag_constraints/+merge/126502
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~gz/maas/cpu_mem_tag_constraints into lp:maas.