launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

The proposal to merge lp:~abentley/launchpad/storm-sprint-queries into lp:launchpad has been updated.

Description changed to:

= Summary =
Update Sprint.specifications to use storm expressions

== Pre-implementation notes ==
None

== LOC Rationale ==
Part of private projects

== Implementation details ==
Convert Sprint.specifications to use storm expressions, so that we can add privacy checks.  Also, remove support for prejoin_people.  This is justifiable because with the new code, the Sprint index page actually emits fewer queries.  Since sorting by priority is the default, it is not explicitly implemented.

Reduce the signature of specificationLinks to those values that are actually used.

Tweak specificationtarget-assignments.pt, because it relied on the old ResultSet evaluating False when it was empty.

Implement stormexpr.fti_search because it was needed to emit a Storm expression.

== Tests ==
bin/test test_sprint

== Demo and Q/A ==
The sprint pages should work, and should list relevant blueprints.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/services/database/stormexpr.py
  lib/lp/blueprints/templates/specificationtarget-assignments.pt
  lib/lp/blueprints/model/tests/test_sprint.py
  lib/lp/blueprints/model/specification.py
  lib/lp/blueprints/model/sprint.py
  lib/lp/testing/_webservice.py
  lib/lp/blueprints/browser/tests/test_sprint.py

For more details, see:
https://code.launchpad.net/~abentley/launchpad/storm-sprint-queries/+merge/126770
-- 
https://code.launchpad.net/~abentley/launchpad/storm-sprint-queries/+merge/126770
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~abentley/launchpad/storm-sprint-queries into lp:launchpad.