launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #12695
Re: [Merge] lp:~rvb/maas/add-maas-cluster-packaging into lp:~maas-maintainers/maas/packaging
Review: Approve
Looks good to me.
So I can see celeryconfig_common.py is the one that contains common configuration which is not meant to be modified by the admin right?
Given that is common, I'm guessing that maas_local_celeryconfig.py in region-controller is used to modify those default values in celeryconfig_common.py. If so, shouldn't cluster-controller also need the same?
I don't know whether this is possible or not, but it would be great if we could get rid of the common stuff so that we can avoid having maas-common. Let's talk on monday.
--
https://code.launchpad.net/~rvb/maas/add-maas-cluster-packaging/+merge/127002
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/add-maas-cluster-packaging into lp:~maas-maintainers/maas/packaging.
Follow ups
References