launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~wallyworld/launchpad/announcements-timeout-1068013 into lp:launchpad.

Commit message:
Remove erroneous listification of announcements result set.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1068013 in Launchpad itself: "+announcements timeout"
  https://bugs.launchpad.net/launchpad/+bug/1068013

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/announcements-timeout-1068013/+merge/130441

Remove erroneous listification of announcements result set. Internal change to revert mistake from a previous branch.
-- 
https://code.launchpad.net/~wallyworld/launchpad/announcements-timeout-1068013/+merge/130441
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/announcements-timeout-1068013 into lp:launchpad.

=== modified file 'lib/lp/registry/browser/announcement.py'
--- lib/lp/registry/browser/announcement.py	2012-10-12 01:56:34 +0000
+++ lib/lp/registry/browser/announcement.py	2012-10-18 22:17:22 +0000
@@ -298,8 +298,8 @@
     @cachedproperty
     def announcements(self):
         published_only = not check_permission('launchpad.Edit', self.context)
-        return list(self.context.getAnnouncements(
-                    limit=None, published_only=published_only))
+        return self.context.getAnnouncements(
+                    limit=None, published_only=published_only)
 
     @cachedproperty
     def latest_announcements(self):