launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Firstly, the thing I'm arguing for is two denormalized *columns* on Specification which means you don't need to JOIN against APG and APGF. However, I'm not going to block this MP with this particular point.

    AND (
        Specification.information_type IN (NULL, 1)

This, however, I will block on. You can't use NULL inside an IN, it will compile as SQL, but you are likely getting results you don't expect.
-- 
https://code.launchpad.net/~abentley/launchpad/person-assigned-specs-in-progress/+merge/130888
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.