launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12-10-25 12:29 AM, Steve Kowalik wrote:
> AND ( Specification.information_type IN (NULL, 1)
> 
> This, however, I will block on. You can't use NULL inside an IN, it
> will compile as SQL, but youI are likely getting results you don't
> expect.

That SQL is not the actual SQL.  We called storm.expr.compile to get
the expression, but this left us with a bunch of ? to fill in, and we
filled that part in incorrectly.  The actual values that Launchpad
uses are: (1,2) i.e. PUBLIC and PUBLICSECURITY.

If there is a bug in get_specification_privacy filters, that is not a
bug in my code, so please do not block my branch on that basis.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iEYEARECAAYFAlCI6AsACgkQ0F+nu1YWqI2DUgCfbbumkODtgiAf6NzVz5UtC43o
xbsAniDAaA78ZYXAlhpFT2vN6D9mKJwc
=fLt9
-----END PGP SIGNATURE-----

-- 
https://code.launchpad.net/~abentley/launchpad/person-assigned-specs-in-progress/+merge/130888
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.