launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Richard Harding has proposed merging lp:~rharding/launchpad/fix_flash_1066898 into lp:launchpad.

Commit message:
Disable green flash animation when changing the information type on project new/edit.

Requested reviews:
  Richard Harding (rharding)
Related bugs:
  Bug #1066898 in Launchpad itself: "project edit of information type widget should not flash green"
  https://bugs.launchpad.net/launchpad/+bug/1066898

For more details, see:
https://code.launchpad.net/~rharding/launchpad/fix_flash_1066898/+merge/131529

= Summary =

The information type widget flashes green on save by default even though there's not been an ajax action taken place. We're using it as a normal field widget for project edit and new work. 

== Implementation ==

Just a simple fix to set the flashEnabled to false for our usage.
-- 
https://code.launchpad.net/~rharding/launchpad/fix_flash_1066898/+merge/131529
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/registry/javascript/product_views.js'
--- lib/lp/registry/javascript/product_views.js	2012-10-05 19:50:03 +0000
+++ lib/lp/registry/javascript/product_views.js	2012-10-26 07:08:22 +0000
@@ -24,6 +24,10 @@
             info_type.cache_to_choicesource(
                 LP.cache.information_type_data));
 
+        // We are not doing ajax saves of the information type so we need to
+        // disable the flash on save for the widget.
+        widget.set('flashEnabled', false);
+
         // When the information type changes, check if we should show/hide
         // UI components.
         widget.on('save', function (ev) {