launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

> #31
> 
> How do the errors look when joined?

I think they look fine.  It's basically a one or two line paragraph.

> Since we're just joining with a space I
> wonder if we need to find a way to get into the rendering and force a
> break/new line between errors for display?

I wanted to do that too, but I couldn't find a way to force a line break.  Newlines aren't treated as line breaks, and the angle brackets in HTML tags are escaped using entity references.


> #196
> 
> Party personal question part suggestion. What is an inclusive membership?

One where there are no real restrictions on who can join.

> Since these errors are going to get presented to the user they're going to go
> looking for a way to fix them and I worry that this error won't be clear
> enough to direct users to find/remove the condition.

The team policy descriptions all begin with "Membership is inclusive" or "membership is exclusive", so that is definitely our user-facing terminology.


-- 
https://code.launchpad.net/~abentley/launchpad/more-transition-checks/+merge/136284
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.