launchpad-reviewers team mailing list archive

[Martin Packman <martin.packman@xxxxxxxxxxxxx>]

I've made the updates suggested, and hopefully fixed the issue that caused the (wrong) failure on test run, though it was a little mysterious:

======================================================================
FAIL: maas-integration.TestMAASIntegration.test_15A_apply_tag
----------------------------------------------------------------------
_StringException: maas-cli maas ['tags', 'new', "name='all'", "definition='true'", "comment='A tag present on all nodes'"]: {{{('{"name": ["Enter a valid value."]}\n', '')}}}

Traceback (most recent call last):
  File "/tmp/tmp.KseYMt4gdc/ubtree0-ubtree/debian/tests/maas-integration.py", line 423, in test_15A_apply_tag
    self.assertEqual(tag['name'], "all")
MismatchError: ['Enter a valid value.'] != 'all'


----------------------------------------------------------------------

Why is that coming out in a {'name': ...} keyed dict, and where's the code that's doing that... My assumption is it's the checking that the tag name is simple characters only, and removing the over quoting should fix it.
-- 
https://code.launchpad.net/~gz/maas/qa-lab-tests-maas-tags/+merge/149652
Your team MAAS Maintainers is requested to review the proposed merge of lp:~gz/maas/qa-lab-tests-maas-tags into lp:~maas-maintainers/maas/qa-lab-tests.