launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

[0]

15	+    @timeout(10*60)

Isn't this a bit too long?  We can adjust that later if we have no idea how long it should take to update the nodes, but a timeout of 2x the normal time it should take would seem more reasonable to me.  The rationale for this is that the lab is a precious resource and we should not wait too long in tests before failing.

[1]

>    self.assertEqual(tag['name'], "all")
> MismatchError: ['Enter a valid value.'] != 'all'

The validation of the input failed and the result is a json object like this:
{
'name of the first field which failed validation': 'error1',
'name of the second field which failed validation': 'error2',
...
}
-- 
https://code.launchpad.net/~gz/maas/qa-lab-tests-maas-tags/+merge/149652
Your team MAAS Maintainers is requested to review the proposed merge of lp:~gz/maas/qa-lab-tests-maas-tags into lp:~maas-maintainers/maas/qa-lab-tests.