launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

[2]

+# -*- coding: utf-8 -*-

I don't see why this is required…?
(fwiw, the only file with that are the auto-generated migration files)

PS: I suspect this is just because of → … s/→/->/ ?

[3]

76	+    try:
77	+        legacy_user = User.objects.get(username=legacy_user_name)

If a migrations runs and we are in a position to run that code (i.e. more than one user, no 'provider-state' file), if it happens that there is a *real* user with that username, it won't do the right thing.  I reckon this is pretty improbable but maybe we should at least raise and exception in that case.  What do you think?
-- 
https://code.launchpad.net/~allenap/maas/shared-to-per-tenant-storage/+merge/151858
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/maas/shared-to-per-tenant-storage into lp:maas.