launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

The proposal to merge lp:~stevenk/launchpad/workitems-delete-series into lp:launchpad has been updated.

Description changed to:

This branch is sadly now misnamed, since it has grown in scope quite a bit.

ProductSeries and Milestone deletion would not handle a specification that was invisible to the currently logged in user, which would lead to an OOPS in the milestone case, or a specification targeted to the now obsolete-junk series in the series case.

Worse, workitems were not handled at all in the milestone case, which makes deleting a milestone that contained milestones fraught with peril, since the code might miss a workitem, and then you get an easily reproduced OOPS.

IHasSpecifications._all_specifications has been renamed to visible_specifications since it filters by the current logged in user via ILaunchBag, and left exported as all_specifications.

IMilestone and IProductSeries have grown a all_specifications property which returns all specifications, irregardless if the current logged in user can see them or not.

I have performed a little bit of clean-up, but not enough to force this branch to be net-negative.

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/workitems-delete-series/+merge/156457
-- 
https://code.launchpad.net/~stevenk/launchpad/workitems-delete-series/+merge/156457
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/workitems-delete-series into lp:launchpad.