launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

Raphaël Badin has proposed merging lp:~rvb/juju-core/assignementpolicy into lp:~maas-maintainers/juju-core/maas-provider-skeleton.

Commit message:
Implement AssignmentPolicy().

Requested reviews:
  MAAS Maintainers (maas-maintainers)

For more details, see:
https://code.launchpad.net/~rvb/juju-core/assignementpolicy/+merge/156879
-- 
https://code.launchpad.net/~rvb/juju-core/assignementpolicy/+merge/156879
Your team MAAS Maintainers is requested to review the proposed merge of lp:~rvb/juju-core/assignementpolicy into lp:~maas-maintainers/juju-core/maas-provider-skeleton.

=== modified file 'environs/maas/environ.go'
--- environs/maas/environ.go	2013-03-28 11:01:15 +0000
+++ environs/maas/environ.go	2013-04-03 15:05:26 +0000
@@ -536,7 +536,7 @@
 }
 
 func (*maasEnviron) AssignmentPolicy() state.AssignmentPolicy {
-	panic("Not implemented.")
+	return state.AssignUnused
 }
 
 func (*maasEnviron) OpenPorts([]state.Port) error {

=== modified file 'environs/maas/environ_test.go'
--- environs/maas/environ_test.go	2013-03-28 11:01:15 +0000
+++ environs/maas/environ_test.go	2013-04-03 15:05:26 +0000
@@ -331,3 +331,9 @@
 	err := environs.Bootstrap(env, true, fakeWriteCertAndKey)
 	c.Assert(err, IsNil)
 }
+
+func (suite *EnvironSuite) TestAssignmentPolicy(c *C) {
+	env := suite.makeEnviron()
+
+	c.Check(env.AssignmentPolicy(), Equals, state.AssignUnused)
+}