launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #15451
[Merge] lp:~rvb/gomaasapi/record-action-params into lp:gomaasapi
The proposal to merge lp:~rvb/gomaasapi/record-action-params into lp:gomaasapi has been updated.
Description changed to:
I chose to add another field named "nodeOperationRequestValues" instead of making the existing one (TestServer.nodeOperations) more complex because the new structure would have been a pain to manipulate in Go.
The main reason behind that change is so that we can check that the provider sends the correct "user data" when starting a node: https://code.launchpad.net/~rvb/juju-core/fix-test-start-instance/+merge/158116.
For more details, see:
https://code.launchpad.net/~rvb/gomaasapi/record-action-params/+merge/158117
--
https://code.launchpad.net/~rvb/gomaasapi/record-action-params/+merge/158117
Your team MAAS Maintainers is requested to review the proposed merge of lp:~rvb/gomaasapi/record-action-params into lp:gomaasapi.
References