launchpad-reviewers team mailing list archive

[Diogo Matsubara <matsubara@xxxxxxxxxxxxx>]

Diogo Matsubara has proposed merging lp:~matsubara/maas/fix-maas-cluster-controller-sed into lp:~maas-maintainers/maas/packaging.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1167660 in maas (Ubuntu): "maas-cluster-controller.postinst failing with an unterminated sed error"
  https://bugs.launchpad.net/ubuntu/+source/maas/+bug/1167660

For more details, see:
https://code.launchpad.net/~matsubara/maas/fix-maas-cluster-controller-sed/+merge/158262

Fix sed quoting in maas-cluster-controller.postinst to avoid package installation failure.

See bug 1167660
-- 
https://code.launchpad.net/~matsubara/maas/fix-maas-cluster-controller-sed/+merge/158262
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~matsubara/maas/fix-maas-cluster-controller-sed into lp:~maas-maintainers/maas/packaging.

=== modified file 'debian/maas-cluster-controller.postinst'
--- debian/maas-cluster-controller.postinst	2013-03-19 20:01:31 +0000
+++ debian/maas-cluster-controller.postinst	2013-04-11 01:43:22 +0000
@@ -83,7 +83,7 @@
     # Get the MAAS_URL on configure/reconfigure and write it to the conf files.
     db_get maas-cluster-controller/maas-url || true
     if [ -n "$RET" ]; then
-        sed -i "s|MAAS_URL=.*|MAAS_URL="$RET"|" /etc/maas/maas_cluster.conf
+        sed -i "s|MAAS_URL=.*|MAAS_URL='$RET'|" /etc/maas/maas_cluster.conf
         # Extract the hostname part.
         HOSTPART=$(echo $RET|awk '{ split($0,array,"/")} END{print array[3] }')
         # And substitute it in-place in pserv.yaml on an indented, non-commented