launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/juju-core/mpv-fwreade-15 into lp:~maas-maintainers/juju-core/maas-provider-skeleton has been updated.

Description changed to:

I don't see the other providers doing this yet, but since we were already halfway done implementing thumper's global Validate(), it makes sense to validate not just the new config that's being set but the resulting changes as well.

This small branch took surprising amounts of debugging.  The fixes include, en passant, point #20: TestSetConfigUpdatesConfig() can't set a new name for the environment, because that's an invalid state transition.  The test broke.


Jeroen

For more details, see:
https://code.launchpad.net/~jtv/juju-core/mpv-fwreade-15/+merge/158521
-- 
https://code.launchpad.net/~jtv/juju-core/mpv-fwreade-15/+merge/158521
Your team MAAS Maintainers is requested to review the proposed merge of lp:~jtv/juju-core/mpv-fwreade-15 into lp:~maas-maintainers/juju-core/maas-provider-skeleton.