launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/juju-core/fwereade-26 into lp:~maas-maintainers/juju-core/maas-provider-skeleton.

Commit message:
Address fwereade's review comment #26: simpler way to get maasEnvironProvider of the right static type.

Requested reviews:
  MAAS Maintainers (maas-maintainers)

For more details, see:
https://code.launchpad.net/~jtv/juju-core/fwereade-26/+merge/158526

>From fwereade's review of our config branch:

«26) forgot to mention this: env.Provider().(*maasEnvironProvider)

«just use providerInstance?»
-- 
https://code.launchpad.net/~jtv/juju-core/fwereade-26/+merge/158526
Your team MAAS Maintainers is requested to review the proposed merge of lp:~jtv/juju-core/fwereade-26 into lp:~maas-maintainers/juju-core/maas-provider-skeleton.

=== modified file 'environs/maas/environ.go'
--- environs/maas/environ.go	2013-04-12 03:34:33 +0000
+++ environs/maas/environ.go	2013-04-12 04:50:31 +0000
@@ -252,7 +252,7 @@
 		return err
 	}
 
-	ecfg, err := env.Provider().(*maasEnvironProvider).newConfig(cfg)
+	ecfg, err := providerInstance.newConfig(cfg)
 	if err != nil {
 		return err
 	}