launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/juju-core/fwereade-14 into lp:~maas-maintainers/juju-core/maas-provider-skeleton.

Commit message:
Address fwereade's review comment #14: log constraints that we're still ignoring.

Requested reviews:
  MAAS Maintainers (maas-maintainers)

For more details, see:
https://code.launchpad.net/~jtv/juju-core/fwereade-14/+merge/158528

The log level is as suggested by William.


Jeroen
-- 
https://code.launchpad.net/~jtv/juju-core/fwereade-14/+merge/158528
Your team MAAS Maintainers is requested to review the proposed merge of lp:~jtv/juju-core/fwereade-14 into lp:~maas-maintainers/juju-core/maas-provider-skeleton.

=== modified file 'environs/maas/environ.go'
--- environs/maas/environ.go	2013-04-12 03:34:33 +0000
+++ environs/maas/environ.go	2013-04-12 05:01:33 +0000
@@ -143,6 +143,10 @@
 
 // Bootstrap is specified in the Environ interface.
 func (env *maasEnviron) Bootstrap(cons constraints.Value, stateServerCert, stateServerKey []byte) error {
+	constraints := cons.String()
+	if constraints != "" {
+		log.Warningf("ignoring constraints '%s' (not implemented)", constraints)
+	}
 
 	// This was all cargo-culted from the EC2 provider.
 	password := env.Config().AdminSecret()