launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

On Tue, Nov 26, 2013 at 02:44:16AM -0000, William Grant wrote:
> 127	+ def build(self):
> 128	+ if self.options.locale is not None:
> 
> The locale and non-locale cases seem to be almost entirely divergent. Do we really need both?

For the time being, yes, because the Chinese Edition was still built by
Canonical in precise.  That's been superseded by UbuntuKylin now, so
we'll probably be able to get rid of this once we no longer care about
building images for precise (assuming nobody wants us to do a similar
thing again), but not quite yet.

> 365	+ def gatherResults(self):
> 366	+ """Gather the results of the build and add them to the file cache."""
> 367	+ for entry in sorted(os.listdir(self.build_path)):
> 368	+ if entry.startswith("livecd."):
> 369	+ self._slave.addWaitingFile(
> 370	+ os.path.join(self.build_path, entry))
> 
> There's no manifest-like file from which we can parse the build result filenames?

Not right now.  Do you think that's a problem?  If so I'll need to do
some work in livecd-rootfs to set one up.

Perhaps it would be sufficient to just make doubly sure that the build
directory is empty before we start a build?  At the moment it looks like
the old system (livecd-rootfs/BuildLiveCD) relies on the previous build
having cleaned things out, and come to think of it I'm not too sure that
I even preserved that in this launchpad-buildd version, so I'll need to
do something there.

-- 
https://code.launchpad.net/~cjwatson/launchpad-buildd/livefs/+merge/193682
Your team Launchpad code reviewers is subscribed to branch lp:launchpad-buildd.