launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/destroy-twistedjobsource into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/destroy-twistedjobsource/+merge/199070

While working through another change, I stumbled over this duplication in branchmergeproposal. Clean it up, and as a consequence, ITwistedJobSource can die too.
-- 
https://code.launchpad.net/~stevenk/launchpad/destroy-twistedjobsource/+merge/199070
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/destroy-twistedjobsource into lp:launchpad.

=== modified file 'lib/lp/code/interfaces/branchmergeproposal.py'
--- lib/lp/code/interfaces/branchmergeproposal.py	2013-04-29 00:10:09 +0000
+++ lib/lp/code/interfaces/branchmergeproposal.py	2013-12-16 05:16:48 +0000
@@ -82,7 +82,6 @@
     IJob,
     IJobSource,
     IRunnableJob,
-    ITwistedJobSource,
     )
 from lp.services.webapp.interfaces import ITableBatchNavigator
 
@@ -599,10 +598,6 @@
         """Destroy this object."""
 
 
-class IBranchMergeProposalJobSource(ITwistedJobSource):
-    """A job source that will get all supported merge proposal jobs."""
-
-
 class IBranchMergeProposalJobSource(IJobSource):
     """A job source that will get all supported merge proposal jobs."""
 

=== modified file 'lib/lp/services/job/interfaces/job.py'
--- lib/lp/services/job/interfaces/job.py	2013-07-23 16:25:54 +0000
+++ lib/lp/services/job/interfaces/job.py	2013-12-16 05:16:48 +0000
@@ -9,7 +9,6 @@
     'IJob',
     'IJobSource',
     'IRunnableJob',
-    'ITwistedJobSource',
     'JobStatus',
     'JobType',
     ]
@@ -218,10 +217,3 @@
 
     def contextManager():
         """Get a context for running this kind of job in."""
-
-
-class ITwistedJobSource(IJobSource):
-    """Interface for a job source that is usable by the TwistedJobRunner."""
-
-    def get(id):
-        """Get a job by its id."""