launchpad-reviewers team mailing list archive

[Chris Johnston <chris.johnston@xxxxxxxxxxxxx>]

Chris Johnston has proposed merging lp:~cjohnston/launchpad/1324486 into lp:launchpad.

Commit message:
Add the ability to not have a 'read more' in the beta banner, remove link from beta banner for IC

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1324486 in Launchpad itself: "banner for beta diff comments points to non-existant URL"
  https://bugs.launchpad.net/launchpad/+bug/1324486

For more details, see:
https://code.launchpad.net/~cjohnston/launchpad/1324486/+merge/221410
-- 
https://code.launchpad.net/~cjohnston/launchpad/1324486/+merge/221410
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjohnston/launchpad/1324486 into lp:launchpad.

=== modified file 'lib/lp/app/javascript/ui/banner.js'
--- lib/lp/app/javascript/ui/banner.js	2012-11-09 18:55:02 +0000
+++ lib/lp/app/javascript/ui/banner.js	2014-05-29 15:09:32 +0000
@@ -226,9 +226,15 @@
                                content = content + [
                                  '<span class="beta-feature">',
                                  obj.title,
-                                 '&nbsp;<a class="info-link" href="',
-                                 obj.url + '">(read more)</a>',
-                                 '</span>'
+                                 ].join('')
+                               if (obj.url !== '') {
+                                   content = content + [
+                                       '&nbsp;<a class="info-link" href="',
+                                       obj.url + '">(read more)</a>',
+                                   ].join('')
+                               }
+                               content = content + [
+                                   '</span>'
                                ].join('');
                            }
                         }

=== modified file 'lib/lp/services/features/flags.py'
--- lib/lp/services/features/flags.py	2014-05-28 22:03:06 +0000
+++ lib/lp/services/features/flags.py	2014-05-29 15:09:32 +0000
@@ -226,7 +226,7 @@
      'If true, reviewers can comment on parts of merge proposal diffs.',
      'disabled',
      'Inline diff comments',
-     'http://blog.launchpad.net/general/diff-comments'),
+     ''),
     ])
 
 # The set of all flag names that are documented.