launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~cjohnston/launchpad/short-ic-emails into lp:launchpad

To: Chris Johnston <chris.johnston@xxxxxxxxxxxxx>
From: Celso Providelo <celso.providelo@xxxxxxxxxxxxx>
Date: Fri, 11 Jul 2014 01:51:14 -0000
In-reply-to: <20140630231033.691.27146.launchpad@ackee.canonical.com>
Reply-to: mp+225095@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

lib/lp/services/patches.py is a much better place, the code style there still alien to LP, it reads very differently. But I am not opposed to landing it this way if you think it will be closer to the original bzrlib, thus easier to maintain up to date.

Looks good for landing and get some feedback from users, possibly experimenting with including previous comments too.

Good work!
-- 
https://code.launchpad.net/~cjohnston/launchpad/short-ic-emails/+merge/225095
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~cjohnston/launchpad/short-ic-emails into lp:launchpad
From: Chris Johnston, 2014-06-30