launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~cjohnston/launchpad/short-ic-emails into lp:launchpad

To: Chris Johnston <chris.johnston@xxxxxxxxxxxxx>
From: William Grant <me@xxxxxxxxxxxxxxxxxx>
Date: Fri, 11 Jul 2014 02:55:45 -0000
In-reply-to: <20140630231033.691.27146.launchpad@ackee.canonical.com>
Reply-to: mp+225095@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

lp.services.patches should say somewhere that it's derived from bzrlib.patches, what the changes are, and why. It might also be possible to push these improvements back to bzrlib.patches in a backward-compatible way later.

The new set of test files doesn't give any tests for inline comments across multiple files, just multiple hunks. That should probably be fixed.
-- 
https://code.launchpad.net/~cjohnston/launchpad/short-ic-emails/+merge/225095
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~cjohnston/launchpad/short-ic-emails into lp:launchpad
From: Chris Johnston, 2014-06-30