launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing code

Line numbers jump ahead by one at the boundary between file, as visible in expected-6: the comment in the second file is rendered a line too late, and the comment in the third is two lines late. I assume the trailing newline isn't being counted.

Also, it probably makes sense to have a gap between hunks, at least when one is skipped. In expected-6, the hunk at 70 seems to lead directly into 88, but in the original there's one at 80.

Additionally, does expected-1 give any value over expected-6?
-- 
https://code.launchpad.net/~cjohnston/launchpad/short-ic-emails/+merge/225095
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.