launchpad-reviewers team mailing list archive

[Chris Johnston <chris.johnston@xxxxxxxxxxxxx>]

> Also, it probably makes sense to have a gap between hunks, at least when one
> is skipped. In expected-6, the hunk at 70 seems to lead directly into 88, but
> in the original there's one at 80.

How do you suggest doing the gap? A blank line or a line that starts with '>', or maybe even some sort of text to indicate that a hunk is skipped? Also, how do you want to handle if multiple hunks in a row (or even a whole file) are mising? One line for each hunk missing, one line total, if a file is missing and it's the first file should we start out with a blank line? I almost think that we should see what type of feedback we get the way things are and then iterate again.


> Additionally, does expected-1 give any value over expected-6?

Just the fact that it's a very simple diff with only one file, so just trying to cover one more case where things are different.
-- 
https://code.launchpad.net/~cjohnston/launchpad/short-ic-emails/+merge/225095
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.