launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~cjwatson/launchpad/bpph-source into lp:launchpad

To: Colin Watson <cjwatson@xxxxxxxxxxxxx>
From: William Grant <me@xxxxxxxxxxxxxxxxxx>
Date: Mon, 06 Apr 2015 23:23:46 -0000
In-reply-to: <20150402113722.4416.15548.launchpad@ackee.canonical.com>
Reply-to: mp+255070@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code

It may be acceptable to make this BinaryPackageBuild.getPublishedSource, but it's certainly not BinaryPackagePublishingHistory.getPublishedSource -- it can return a publication in a totally different archive.

If you just want the source name, I'd expose BinaryPackageBuild.source_package_name instead.
-- 
https://code.launchpad.net/~cjwatson/launchpad/bpph-source/+merge/255070
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~cjwatson/launchpad/bpph-source into lp:launchpad
From: Colin Watson, 2015-04-02