launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #18366
Re: [Merge] lp:~blr/turnip/api-init-with-alternates into lp:turnip
Wouldn't it make sense to unify this with DiffMergeAPI, and just have it test whether there's a colon in the provided {name}? Similarly for DiffAPI, although DiffMergeAPI is where we need this most urgently as it's blocking many of the natural uses of preview diffs for merge proposals. It doesn't seem to make sense to have an entire separate view for cross-repository diffs; from Launchpad's point of view, it's generally requesting a diff between two {repository, SHA1} pairs, where the two repositories may or may not be identical.
--
https://code.launchpad.net/~blr/turnip/api-init-with-alternates/+merge/256715
Your team Launchpad code reviewers is subscribed to branch lp:turnip.
References