launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~blr/turnip/api-init-with-alternates into lp:turnip

To: mp+256715@xxxxxxxxxxxxxxxxxx
From: Bayard 'kit' Randel <kit.randel@xxxxxxxxxxxxx>
Date: Mon, 27 Apr 2015 20:49:05 -0000
In-reply-to: <20150417213920.16389.75768.launchpad@ackee.canonical.com>
Reply-to: mp+256715@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Yes we can certainly do that - my preference for the separate class was to make the routing more explicit, but given we are already regex'ing matchdicts elsewhere, this might be okay. Is 'compare-merge' an appropriate verb for a cross repository diff? 

I would also be inclined to change the route for the DiffMergeAPI to:

@resource(path='/repo/{name}/compare-merge/{base}:{head}')
-- 
https://code.launchpad.net/~blr/turnip/api-init-with-alternates/+merge/256715
Your team Launchpad code reviewers is subscribed to branch lp:turnip.

References

[Merge] lp:~blr/turnip/api-init-with-alternates into lp:turnip
From: Bayard 'kit' Randel, 2015-04-17