launchpad-reviewers team mailing list archive

[Bayard 'kit' Randel <kit.randel@xxxxxxxxxxxxx>]

Bayard 'kit' Randel has proposed merging lp:~blr/launchpad/recent-commits-link-cgit-ref into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~blr/launchpad/recent-commits-link-cgit-ref/+merge/258749

A trivial template update, linking the shortened sha1 in recent commits for view '+git/agitproject/+ref/branch', to the ref on cgit.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~blr/launchpad/recent-commits-link-cgit-ref into lp:launchpad.

=== modified file 'lib/lp/code/templates/gitref-macros.pt'
--- lib/lp/code/templates/gitref-macros.pt	2015-03-19 17:04:22 +0000
+++ lib/lp/code/templates/gitref-macros.pt	2015-05-11 12:08:21 +0000
@@ -18,7 +18,9 @@
         sha1 python:commit_info['sha1'];
         author python:commit_info['author'];
         author_date python:commit_info['author_date']">
-    <tal:sha1 replace="sha1/fmt:shorten/10" />
+   <a tal:attributes="href string:${context/repository/getCodebrowseUrl}/commit/?id=${sha1}">
+     <tal:sha1 replace="sha1/fmt:shorten/10" />
+   </a>
     by
     <tal:known-person condition="author/person">
       <tal:person-link replace="structure author/person/fmt:link" />