launchpad-reviewers team mailing list archive

[Thomi Richards <thomi.richards@xxxxxxxxxxxxx>]

Thomi Richards has proposed merging lp:~thomir/launchpad/devel-add-ssh-private-api into lp:launchpad.

Commit message:
Add API method to retrieve all SSH keys for a user, for integration with SSO.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~thomir/launchpad/devel-add-ssh-private-api/+merge/295411

Add API method to retrieve all SSH keys for a user, for integration with SSO.

Note: There's several places in the code where the conversion from SSHKeyType to 'ssh-rsa' and 'ssh-dss' strings are done. Is it worth doing something to SSHKeyType so these call-sites can just use that type to do the conversion? That way, if new key types are ever added it'll be easier to update.... Thoughts?
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~thomir/launchpad/devel-add-ssh-private-api into lp:launchpad.