launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> === modified file 'lib/lp/registry/browser/person.py'
> --- lib/lp/registry/browser/person.py	2016-03-09 02:33:27 +0000
> +++ lib/lp/registry/browser/person.py	2016-05-23 03:10:26 +0000
> @@ -195,6 +195,7 @@
>      SSHKeyAdditionError,
>      SSHKeyCompromisedError,
>      SSHKeyType,
> +    SSHKeyTypeToText,

This import looks unused now.

>      )
>  from lp.registry.interfaces.teammembership import (
>      ITeamMembershipSet,
> 
> === modified file 'lib/lp/registry/interfaces/ssh.py'
> --- lib/lp/registry/interfaces/ssh.py	2015-10-26 14:54:43 +0000
> +++ lib/lp/registry/interfaces/ssh.py	2016-05-23 03:10:26 +0000
> @@ -51,6 +51,12 @@
>          """)
>  
>  
> +SSHKeyTypeToText = {
> +    SSHKeyType.RSA: "ssh-rsa",
> +    SSHKeyType.DSA: "ssh-dss",
> +}

Constants are usually ALLCAPS_WITH_UNDERSCORES.

> +
> +
>  class ISSHKey(Interface):
>      """SSH public key"""
>  


-- 
https://code.launchpad.net/~thomir/launchpad/devel-add-ssh-private-api/+merge/295411
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.