launchpad-reviewers team mailing list archive

[Andy Whitcroft <apw@xxxxxxxxxxxxx>]

Andy Whitcroft has proposed merging lp:~apw/launchpad/signing-permissions into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1577736 in Launchpad itself: "Expand archive signing to kernel modules"
  https://bugs.launchpad.net/launchpad/+bug/1577736

For more details, see:
https://code.launchpad.net/~apw/launchpad/signing-permissions/+merge/295616

Fix the permissions of newly created Kmod signing x509 certificates.

This is public information there is no need for them to be private.  Make sure these are readable after creation.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~apw/launchpad/signing-permissions into lp:launchpad.

=== modified file 'lib/lp/archivepublisher/signing.py'
--- lib/lp/archivepublisher/signing.py	2016-05-23 10:18:21 +0000
+++ lib/lp/archivepublisher/signing.py	2016-05-24 18:07:17 +0000
@@ -267,6 +267,9 @@
         finally:
             os.umask(old_mask)
 
+        if os.path.exists(self.kmod_x509):
+            os.chmod(self.kmod_x509, 0o644)
+
     def signKmod(self, image):
         """Attempt to sign a kernel module."""
         remove_if_exists("%s.sig" % image)