launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Needs Fixing

Could you add a test as well?  I think you could reasonably just tack a stat check onto the end of test_create_kmod_keys_autokey_on, and that would also be a good place to check (more importantly) that kmod.pem isn't world-readable.
-- 
https://code.launchpad.net/~apw/launchpad/signing-permissions/+merge/295616
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.