launchpad-reviewers team mailing list archive

[Maximiliano Bertacchini <maximiliano.bertacchini@xxxxxxxxxxxxx>]

Updated with improved wording.

Diff comments:

> === modified file 'lib/lp/snappy/browser/snap.py'
> --- lib/lp/snappy/browser/snap.py	2016-07-16 07:46:23 +0000
> +++ lib/lp/snappy/browser/snap.py	2016-07-20 15:26:47 +0000
> @@ -242,11 +242,17 @@
>              Choice(vocabulary='SnapDistroArchSeries'),
>              title=u'Architectures', required=True)
>          pocket = Choice(
> -            title=u'Pocket', vocabulary=PackagePublishingPocket, required=True)
> +            title=u'Pocket', vocabulary=PackagePublishingPocket, required=True,
> +            description=u'The set of packages with which this snap package '
> +                'should be built.')

Used "The package stream within the source distribution series to use when building the snap package."

>  
>      custom_widget('archive', SnapArchiveWidget)
>      custom_widget('distro_arch_series', LabeledMultiCheckBoxWidget)
>  
> +    help_links = {
> +        "pocket": u"/+help-snappy/snap-build-pocket.html",
> +    }
> +
>      @property
>      def cancel_url(self):
>          return canonical_url(self.context)
> 
> === modified file 'lib/lp/snappy/interfaces/snap.py'
> --- lib/lp/snappy/interfaces/snap.py	2016-07-15 17:11:09 +0000
> +++ lib/lp/snappy/interfaces/snap.py	2016-07-20 15:26:47 +0000
> @@ -381,8 +381,8 @@
>          title=_("Pocket for automatic builds"),
>          vocabulary=PackagePublishingPocket, required=False, readonly=False,
>          description=_(
> -            "The pocket for which automatic builds of this snap package "
> -            "should be built.")))
> +            "The set of packages with which automatic builds of this snap "
> +            "package should be built.")))

This text is used to build the +new-snap and +edit forms, so I had to change it.

>  
>      is_stale = Bool(
>          title=_("Snap package is stale and is due to be rebuilt."),


-- 
https://code.launchpad.net/~maxiberta/launchpad/snap-pocket-help/+merge/300626
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.