launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

The proposal to merge lp:~cjwatson/launchpad/fix-dsp-vocab-picker into lp:launchpad has been updated.

Description changed to:

Customise the picker for DistributionSourcePackageVocabulary to make vocabulary requests in the context of the currently-selected distribution.  Otherwise the vocabulary only works if explicitly given the <distro>/<package> search format, which isn't very user-friendly.

I've also changed the vocabulary itself to return just the package name as the term's token and title, rather than distribution/package.  This is less strictly correct, but given that it's always being fed into a package name text box it works a lot better in practice (we don't want that text box to receive e.g. "ubuntu/firefox"), and since the vocabulary always has its distribution context set from somewhere else it works fine in practice.

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/fix-dsp-vocab-picker/+merge/300782
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/fix-dsp-vocab-picker into lp:launchpad.