launchpad-reviewers team mailing list archive

[Maximiliano Bertacchini <maximiliano.bertacchini@xxxxxxxxxxxxx>]

Maximiliano Bertacchini has proposed merging lp:~maxiberta/launchpad/snap-pocket-help-icon-placement into lp:launchpad.

Commit message:
Improve placement of Snap build pocket help icon.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/snap-pocket-help-icon-placement/+merge/300959

Improve placement of Snap build pocket help icon.

Snap pocket related widgets are now rendered with `LaunchpadDropdownWidget`, which does not wrap its contents with a `<div>`, instead of the default `DropdownWidget`. As a result, the help icon is placed at the right of the dropdown selector instead of a new line.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~maxiberta/launchpad/snap-pocket-help-icon-placement into lp:launchpad.

=== modified file 'lib/lp/snappy/browser/snap.py'
--- lib/lp/snappy/browser/snap.py	2016-07-21 15:37:04 +0000
+++ lib/lp/snappy/browser/snap.py	2016-07-22 22:03:32 +0000
@@ -50,6 +50,7 @@
 from lp.app.interfaces.launchpad import ILaunchpadCelebrities
 from lp.app.widgets.itemswidgets import (
     LabeledMultiCheckBoxWidget,
+    LaunchpadDropdownWidget,
     LaunchpadRadioWidget,
     )
 from lp.buildmaster.interfaces.processor import IProcessorSet
@@ -248,6 +249,7 @@
 
     custom_widget('archive', SnapArchiveWidget)
     custom_widget('distro_arch_series', LabeledMultiCheckBoxWidget)
+    custom_widget('pocket', LaunchpadDropdownWidget)
 
     help_links = {
         "pocket": u"/+help-snappy/snap-build-pocket.html",
@@ -382,6 +384,7 @@
     custom_widget('store_distro_series', LaunchpadRadioWidget)
     custom_widget('auto_build_archive', SnapArchiveWidget)
     custom_widget('store_channels', LabeledMultiCheckBoxWidget)
+    custom_widget('auto_build_pocket', LaunchpadDropdownWidget)
 
     help_links = {
         "auto_build_pocket": u"/+help-snappy/snap-build-pocket.html",
@@ -673,6 +676,7 @@
     custom_widget('vcs', LaunchpadRadioWidget)
     custom_widget('git_ref', GitRefWidget)
     custom_widget('auto_build_archive', SnapArchiveWidget)
+    custom_widget('auto_build_pocket', LaunchpadDropdownWidget)
 
     help_links = {
         "auto_build_pocket": u"/+help-snappy/snap-build-pocket.html",