launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> === modified file 'lib/lp/code/xmlrpc/codeimportscheduler.py'
> --- lib/lp/code/xmlrpc/codeimportscheduler.py	2016-10-11 13:46:57 +0000
> +++ lib/lp/code/xmlrpc/codeimportscheduler.py	2016-10-11 13:46:57 +0000
> @@ -69,10 +69,10 @@
>          job = self._getJob(job_id)
>          arguments = CodeImportSourceDetails.fromCodeImportJob(
>              job).asArguments()
> -        branch = job.code_import.branch
> -        branch_url = canonical_url(branch)
> -        log_file_name = '%s.log' % branch.unique_name[1:].replace('/', '-')
> -        return (arguments, branch_url, log_file_name)
> +        target = job.code_import.target
> +        target_url = canonical_url(target)
> +        log_file_name = '%s.log' % target.unique_name[1:].replace('/', '-')
> +        return (arguments, target_url, log_file_name)

One of these days I think every concept will be named "target".

>  
>      @return_fault
>      def _updateHeartbeat(self, job_id, log_tail):


-- 
https://code.launchpad.net/~cjwatson/launchpad/codeimport-worker-refactor/+merge/308122
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.