launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/code/model/tests/test_codeimport.py'
> --- lib/lp/code/model/tests/test_codeimport.py	2016-10-03 17:00:56 +0000
> +++ lib/lp/code/model/tests/test_codeimport.py	2016-10-11 14:42:21 +0000
> @@ -66,15 +67,22 @@
>              "supports_source_cvs": True,
>              "supports_source_svn": True,
>              "supports_source_bzr": True,
> +            "needs_hosting_fixture": False,

needs_git_hosting_fixture surely?

>              }),
>          ("GitRepository", {
>              "target_rcs_type": TargetRevisionControlSystems.GIT,
>              "supports_source_cvs": False,
>              "supports_source_svn": False,
>              "supports_source_bzr": False,
> +            "needs_hosting_fixture": True,
>              }),
>          ]
>  
> +    def setUp(self, *args, **kwargs):
> +        super(TestCodeImportBase, self).setUp(*args, **kwargs)
> +        if self.needs_hosting_fixture:
> +            self.hosting_fixture = self.useFixture(GitHostingFixture())
> +
>  
>  class TestCodeImportCreation(TestCodeImportBase):
>      """Test the creation of CodeImports."""


-- 
https://code.launchpad.net/~cjwatson/launchpad/codeimport-create-hosting/+merge/308132
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.