launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/registry/model/personproduct.py'
> --- lib/lp/registry/model/personproduct.py	2015-07-08 16:05:11 +0000
> +++ lib/lp/registry/model/personproduct.py	2017-05-26 17:23:18 +0000
> @@ -45,3 +45,11 @@
>  
>      def __ne__(self, other):
>          return not self == other
> +
> +    @property
> +    def private(self):
> +        return self.person.private or self.product.private
> +
> +    @property
> +    def information_type(self):
> +        return self.product.information_type

Is this going to look weird for a private team on a public project?



-- 
https://code.launchpad.net/~cjwatson/launchpad/person-product-privacy/+merge/324693
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.