launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Diff comments:

> 
> === modified file 'lib/lp/registry/model/personproduct.py'
> --- lib/lp/registry/model/personproduct.py	2015-07-08 16:05:11 +0000
> +++ lib/lp/registry/model/personproduct.py	2017-05-26 17:23:18 +0000
> @@ -45,3 +45,11 @@
>  
>      def __ne__(self, other):
>          return not self == other
> +
> +    @property
> +    def private(self):
> +        return self.person.private or self.product.private
> +
> +    @property
> +    def information_type(self):
> +        return self.product.information_type

It doesn't seem to, or at least no more than it already does.  On PersonProduct:+git you do get a "New repositories for <project> are Public" message, but that isn't dependent on what's defined here.

However, implementing IInformationType is also not doing anything particularly useful here, and it's arguably misleading, so I've removed it and just implemented IPrivacy.



-- 
https://code.launchpad.net/~cjwatson/launchpad/person-product-privacy/+merge/324693
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.