launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

The proposal to merge lp:~cjwatson/launchpad-buildd/fix-core-snap-installation into lp:launchpad-buildd has been updated.

Description changed to:

Installing the core snap has started to require loading AppArmor profiles, which requires capabilities that we were previously dropping.  I don't remember exactly why I dropped those capabilities, but I think it was some combination of an excess of conservatism and cargo-culting from some bit of LXD itself.

After fixing this, some builds still fail because udev isn't installed in all our buildd chroots.  I think this is a missing dependency in snapd and I've filed that as a bug, but in the meantime it's easy to work around it.

I've tested trusty, xenial, and bionic builds with this change.

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad-buildd/fix-core-snap-installation/+merge/333627
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad-buildd/fix-core-snap-installation into lp:launchpad-buildd.