← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~cjwatson/launchpad/ptuj-repr into lp:launchpad

To: Colin Watson <cjwatson@xxxxxxxxxxxxx>
From: Maximiliano Bertacchini <maximiliano.bertacchini@xxxxxxxxxxxxx>
Date: Mon, 26 Feb 2018 16:57:37 -0000
In-reply-to: <151931138135.31838.6119340699031696313.launchpad@ackee.canonical.com>
Reply-to: mp+338559@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Looks good to me. One question though: why move those @properties from `PackageTranslationsUploadJob` to its parent class `PackageTranslationsUploadJobDerived`?
-- 
https://code.launchpad.net/~cjwatson/launchpad/ptuj-repr/+merge/338559
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/ptuj-repr into lp:launchpad.

References

[Merge] lp:~cjwatson/launchpad/ptuj-repr into lp:launchpad
From: Colin Watson, 2018-02-22