launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

That's because we're now using those properties in the parent class, specifically in the new PackageTranslationsUploadJobDerived.__repr__ method.

The whole *Derived thing for jobs is pretty confusing, but basically the job runner calls iterReady on an IJobSource to get the list of jobs it should run, and the returned instances (FooJobDerived) typically delegate to self.context (which is a FooJob) for the business logic of the job proper.  Now, I'm not a big fan of this layout because it's usually unnecessarily complicated, and in this case it's an artificial distinction because self.context == self; however, strictly speaking the job runner's logging is done using the FooJobDerived instance, so __repr__ belongs there and I therefore moved the properties it uses as well.
-- 
https://code.launchpad.net/~cjwatson/launchpad/ptuj-repr/+merge/338559
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/ptuj-repr into lp:launchpad.