launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/snap-max-retries into lp:launchpad.

Commit message:
Bump SnapStoreUploadJob.max_retries to 30 to allow for longer store scan times.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/snap-max-retries/+merge/355211

The store's timeout is currently 18 minutes.

This should probably be a configuration item at some point, but this will do for now.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/snap-max-retries into lp:launchpad.

=== modified file 'lib/lp/snappy/model/snapbuildjob.py'
--- lib/lp/snappy/model/snapbuildjob.py	2018-02-15 21:38:41 +0000
+++ lib/lp/snappy/model/snapbuildjob.py	2018-09-18 14:24:28 +0000
@@ -197,7 +197,7 @@
         )
 
     retry_error_types = (UploadNotScannedYetResponse, RetryableSnapStoreError)
-    max_retries = 20
+    max_retries = 30
 
     config = config.ISnapStoreUploadJobSource