launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~cjwatson/launchpad/snap-max-retries into lp:launchpad

To: Colin Watson <cjwatson@xxxxxxxxxxxxx>
From: Daniel Manrique <daniel.manrique@xxxxxxxxxxxxx>
Date: Tue, 18 Sep 2018 14:27:16 -0000
In-reply-to: <153728073342.7853.16498826844849419259.launchpad@ackee.canonical.com>
Reply-to: mp+355211@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

LGTM. The store's timeout is tunable so we can make that lower easily but for now 18 minutes seems to be what we need. Setting this value to 30 should result in about 27:30 minutes of retries from Launchpad (up from the previous 17:30 which was uncomfortably close to the 18-minute store timeout).

-- 
https://code.launchpad.net/~cjwatson/launchpad/snap-max-retries/+merge/355211
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/snap-max-retries into lp:launchpad.

References

[Merge] lp:~cjwatson/launchpad/snap-max-retries into lp:launchpad
From: Colin Watson, 2018-09-18