launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/ed25519-unsupported-note into lp:launchpad.

Commit message:
Add a UI note that Ed25519 SSH keys are not yet supported.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #907675 in Launchpad itself: "Add support for Ed25519 SSH keys"
  https://bugs.launchpad.net/launchpad/+bug/907675

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/ed25519-unsupported-note/+merge/358580
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/ed25519-unsupported-note into lp:launchpad.

=== modified file 'lib/lp/registry/templates/person-editsshkeys.pt'
--- lib/lp/registry/templates/person-editsshkeys.pt	2018-07-02 14:08:22 +0000
+++ lib/lp/registry/templates/person-editsshkeys.pt	2018-11-09 22:41:48 +0000
@@ -50,6 +50,8 @@
           <code>~/.ssh/id_rsa.pub</code>, <code>~/.ssh/id_dsa.pub</code>, or
           <code>~/.ssh/id_ecdsa.pub</code>).
           Only SSH v2 keys are supported.
+          Ed25519 keys are <a href="https://bugs.launchpad.net/bugs/907675";>not
+          yet supported</a>.
           <a href="https://help.launchpad.net/YourAccount/CreatingAnSSHKeyPair";>
             How do I create a public key?
           </a>