launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code

I wonder if it's better to refactor this to return a list of violations rather than directly logging them and returning False. Some callsites can then log without context if we really want, but the tests can do it less evilly.
-- 
https://code.launchpad.net/~cjwatson/launchpad/refactor-macaroon-testing/+merge/365859
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.